Mark laps as dnf/dq #18

Merged
joaj merged 6 commits from 34-mark-laps-as-dq-dnf into master 2026-06-25 21:19:10 +00:00
Owner

fixes #6

fixes #6
Author
Owner

the bot changes to lap_time are particularly bad

the bot changes to lap_time are particularly bad
joaj force-pushed 34-mark-laps-as-dq-dnf from 9ab72c09c7 to 008da2706a
All checks were successful
/ check (push) Successful in 1m21s
2026-06-22 20:50:08 +00:00
Compare
Mark laps as disqualified (DQ)
Some checks failed
/ check (push) Has been cancelled
84aa6c04be
joaj force-pushed 34-mark-laps-as-dq-dnf from 84aa6c04be
Some checks failed
/ check (push) Has been cancelled
to cd12fd75c8
All checks were successful
/ check (push) Successful in 1m27s
2026-06-22 21:37:14 +00:00
Compare
joaj force-pushed 34-mark-laps-as-dq-dnf from e636404e72
All checks were successful
/ check (push) Successful in 1m28s
to 0834172c3d
Some checks failed
/ check (push) Failing after 1m5s
2026-06-23 21:19:48 +00:00
Compare
joaj force-pushed 34-mark-laps-as-dq-dnf from 0834172c3d
Some checks failed
/ check (push) Failing after 1m5s
to 1e71c5f483
Some checks failed
/ check (push) Failing after 14s
2026-06-23 21:32:03 +00:00
Compare
joaj force-pushed 34-mark-laps-as-dq-dnf from 1e71c5f483
Some checks failed
/ check (push) Failing after 14s
to f369441c54
Some checks failed
/ check (push) Failing after 1m7s
2026-06-23 21:33:02 +00:00
Compare
joaj force-pushed 34-mark-laps-as-dq-dnf from f369441c54
Some checks failed
/ check (push) Failing after 1m7s
to 5403b70e8a
Some checks failed
/ check (push) Failing after 1m5s
2026-06-23 21:37:16 +00:00
Compare
- Add missing status column to lap_times baseline migration
- Add missing lap-times-row-dnf CSS style for DNF row highlighting
- Suppress lap time preview error when trigger count doesn't match discipline rules
Apply DQ to all laps in the same run group
All checks were successful
/ check (push) Successful in 1m25s
1c7e634fba
When a lap is disqualified, all other laps sharing the same
run_group_id are now also disqualified. Laps without a run group
(e.g. AUTOCROSS, ACCELERATION) are updated individually as before.
joaj force-pushed 34-mark-laps-as-dq-dnf from 1c7e634fba
All checks were successful
/ check (push) Successful in 1m25s
to 8f5d8bff22
All checks were successful
/ check (push) Successful in 1m24s
2026-06-24 20:12:59 +00:00
Compare
The explicit DNF path was missing run_group_id and run_lap_index
in the insert_lap_time call, unlike the normal path.
Remove disqualified/disqualified_at columns from code paths
All checks were successful
/ check (push) Successful in 1m26s
99e0d07f79
DQ state is now tracked solely via status='DQ'. The database columns
remain but are no longer referenced in any code path.

- database.py: remove from table def, queries, and set_lap_time_disqualification
- endpoint_lap_time.py: drop disqualified from PATCH response
- LapTimes.jsx: check record.status === 'DQ' instead of record.disqualified
- scoring: derive disqualified from status in LapTime dataclass
- tests: update expected responses and CSV assertions
joaj added this to the MVP milestone 2026-06-25 20:19:47 +00:00
fixup! Remove disqualified/disqualified_at columns from code paths
All checks were successful
/ check (push) Successful in 1m24s
f5b5eaacdd
joaj force-pushed 34-mark-laps-as-dq-dnf from f5b5eaacdd
All checks were successful
/ check (push) Successful in 1m24s
to ce1b5dae59
All checks were successful
/ check (push) Successful in 1m27s
2026-06-25 21:15:28 +00:00
Compare
joaj merged commit 042a5c01c8 into master 2026-06-25 21:19:10 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
fspt/timekeeping!18
No description provided.